[tor-bugs] #20044 [Metrics/CollecTor]: possible NPE in BridgeSnapshotReader

[Tor Bug Tracker & Wiki]

#20044: possible NPE in BridgeSnapshotReader
-----------------------------------+-----------------
     Reporter:  iwakeh             |      Owner:
         Type:  defect             |     Status:  new
     Priority:  Medium             |  Milestone:
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+-----------------
 Just noticed this in BridgeSnapshotReader:

 [https://gitweb.torproject.org/karsten/metrics-
 db.git/tree/src/main/java/org/torproject/collector/bridgedescs/BridgeSnapshotReader.java?h=task-20037&id=46ab6609854e1e2f0c3d55a52f9ada1c2dd59793#n149
 code]
 {{{
                 String firstLine = null;
                 while ((firstLine = br3.readLine()) != null) {
                   if (firstLine.startsWith("@")) {
                     continue;
                   } else {
                     break;
                   }
                 }
                 if (firstLine.startsWith("published ")   // possible NPE?
                     || firstLine.startsWith("flag-thresholds ")
                     || firstLine.startsWith("r ")) {
                   bdp.parse(allData, dateTime, authorityFingerprint);
                   parsedStatuses++;
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20044>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online