[tor-bugs] #19528 [Applications/Tor Browser]: The build id stays the same with every Firefox update

[Tor Bug Tracker & Wiki]

#19528: The build id stays the same with every Firefox update
-----------------------------------------------+---------------------------
 Reporter:  gk                                 |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201608R  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by boklm):

 * keywords:  tbb-gitian, TorBrowserTeam201608 => tbb-gitian,
     TorBrowserTeam201608R
 * status:  needs_revision => needs_review


Comment:

 I pushed a new branch `bug_19528-v4`:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_19528-v4

 In this version we use the date of the git commit to set the year.

 To set the day in the buildid, we take the difference between the ESR
 version and 45, and divide it by 5. We could divide by 7 as there usually
 is an ESR version every 7 versions, but this only works if the difference
 between 2 ESR versions is 7, while dividing by 5 works even if even if the
 difference between 2 ESR versions is not exactly 7 (as long as it is 5 or
 more). We will need to change this around ESR 180 when we will reach day
 28, or before if we start using non-ESR versions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19528#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online