[tor-bugs] #19163 [Core Tor/Tor]: Make sure clients almost always use ntor

[Tor Bug Tracker & Wiki]

#19163: Make sure clients almost always use ntor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201608,     |  implemented
  review-group-7                                 |  Actual Points:  6
Parent ID:                                       |         Points:  2.0
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:22 nickm]:
 > Okay, looks good now!  Merging it.  Please have a look at my merge
 commit (bbaa7d09a045130560a2f5da579671c5e02c9cd7) to make sure that my
 solution for the conflict in routerlist.c didn't reintroduce #19973 .

 The merge commit looks good, apart from the following comment line being
 removed:

 {{{
 -      * if we are making a direct connection */
 }}}

 I'm not too worried about that, because the next line is pretty readable
 even without the comment:

 {{{
  +    if (direct_conn && check_reach &&
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19163#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online