[tor-bugs] #19459 [Applications/Tor Browser]: Write (C++) patch for window resizing parts

[Tor Bug Tracker & Wiki]

#19459: Write (C++) patch for window resizing parts
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton-conversion,            |  Actual Points:
  TorBrowserTeam201608                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  assigned => needs_review


Comment:

 Here's my current patch: https://github.com/arthuredelstein/tor-
 browser/19459

 It's in JavaScript, rather than C++, mainly because the window-sizing
 startup code in Firefox is already in JavaScript.

 I'm not entirely happy with the patch, because it uses a MutationObserver
 to alter the new window's dimensions after the dimensions are otherwise
 stabilized, but before the window is made visible. Unfortunately I wasn't
 able to find a more straightforward way to interject the resizing code.
 Perhaps during an uplift we can get advice on how to improve this
 approach.

 Nonetheless, I do think the code is in approximately the right place
 (browser.js) and should be a workable substitute for our torbutton code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19459#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online