[tor-bugs] #19875 [Core Tor/Tor]: shuffle our bridges when we load them from config

[Tor Bug Tracker & Wiki]

#19875: shuffle our bridges when we load them from config
--------------------------+------------------------------
 Reporter:  arma          |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy          |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------

Comment (by hdevalence):

 Hi.  I got some time to learn how to use Chutney for testing.  I tweaked
 the "bridges" network configuration to have 3 bridges instead of 1, hoping
 to see that (without the patch) the bridge client always selected the
 first one as its guard.  However, this doesn't happen -- the bridge client
 sometimes uses other bridges than the first one.

 entrynodes.c says:
 {{{
 /** A list of configured bridges. Whenever we actually get a descriptor
  * for one, we add it as an entry guard.  Note that the order of bridges
  * in this list does not necessarily correspond to the order of bridges
  * in the torrc. */
 static smartlist_t *bridge_list = NULL;
 }}}
 which is different from the behaviour described at the top of the ticket.
 So, if the order already does not correspond to the order in the torrc,
 I'm not sure how to test that it's shuffled.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19875#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online