[tor-bugs] #17238 [Core Tor/Tor]: prop224: Implement HSDir support

[Tor Bug Tracker & Wiki]

#17238: prop224: Implement HSDir support
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_information
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201608,  |  Actual Points:
  review-group-7, actualreviewpoints=2           |
Parent ID:  #12424                               |         Points:  parent
 Reviewer:  asn                                  |        Sponsor:
                                                 |  SponsorR-must
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_information


Comment:

 I've merged all your things! _minor_ fixes here and there mostly to follow
 some syntax but that's it. I've integrated them in the current commit that
 exists. The `fetch` feature has its own commit as well as the unit test
 for it. Finally, the "make check-spaces happy" is also its own commit.

 On top of all this, I've added a commit for the consensus params
 (discussed in #19899). This is imo ready for a `merge_ready` state that is
 put it in nickm's court.

 @asn, can you confirm your happiness? :) Once you do, I'll create a merge
 request on Gitlab.

 Test code coverage:
 {{{
 src/or/hs_cache.c      - 100%
 src/or/hs_common.c     - 82%     /* Existing code refactored in there. *
 src/or/hs_descriptor.c - 90.7%
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17238#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online