[tor-bugs] #19965 [Core Tor/Tor]: Log torrc option can't handle tab after severity

[Tor Bug Tracker & Wiki]

#19965: Log torrc option can't handle tab after severity
------------------------------+--------------------------
     Reporter:  arma          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 Set your torrc file to be
 {{{
 log debug       file /tmp/debug.log
 }}}
 where that long space is a tab.

 Then {{{tor -f /path/to/torrc}}}
 and you'll get
 {{{
 Aug 23 15:23:49.300 [warn] Couldn't parse log levels in Log option 'Log
 debug        file /tmp/debug.log'
 Aug 23 15:23:49.300 [warn] Failed to parse/validate config: Failed to
 validate Log options. See logs for details.
 Aug 23 15:23:49.300 [err] Reading config failed--see warnings above.
 }}}

 It looks like the issue is in parse_log_severity_config() where we do
 stuff like
 {{{
     space = strchr(cfg, ' ');
 }}}

 Reported by toralf.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19965>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online