[tor-bugs] #19960 [Core Tor/Tor]: Tor v0.2.9.1-alpha-dev (git-b3f43a22ab921ce6) - failing one test on NetBSD

[Tor Bug Tracker & Wiki]

#19960: Tor v0.2.9.1-alpha-dev (git-b3f43a22ab921ce6) - failing one test on NetBSD
-----------------------------------------+---------------------------------
 Reporter:  yancm                        |          Owner:
     Type:  defect                       |         Status:  new
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.2.9.x-final
Component:  Core Tor/Tor                 |        Version:  Tor:
                                         |  0.2.9.1-alpha
 Severity:  Normal                       |     Resolution:
 Keywords:  self test regression netbsd  |  Actual Points:
Parent ID:                               |         Points:
 Reviewer:                               |        Sponsor:
-----------------------------------------+---------------------------------

Comment (by cypherpunks):

 I don't have a NetBSD machine available, but I'm guessing it has something
 to do with #19449. Maybe the change enabled transparent proxying by
 default on NetBSD where it was previously disabled?

 Looking at the test
 (https://gitweb.torproject.org/tor.git/tree/src/test/test_options.c?id=a3d419634bef0bbac4118d08272d59c9fe66a1bb#n1082)
 there isn't a case that tests NetBSD leading to the failed assertion.

 I'll submit a patch that cleans up that part of the code to improve
 readability and fix the incorrect preprocessor variable for detecting
 Linux platforms (`linux` instead of `__linux__`). Because i don't have a
 NetBSD machine I'm unsure which firewall system is used on NetBSD. It
 seems the rest of the Tor code assumes NetBSD is similar to OpenBSD...so i
 guess it should use pf-divert?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19960#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online