[tor-bugs] #19528 [Applications/Tor Browser]: The build id stays the same with every Firefox update

[Tor Bug Tracker & Wiki]

#19528: The build id stays the same with every Firefox update
-----------------------------------------------+---------------------------
 Reporter:  gk                                 |          Owner:  tbb-team
     Type:  defect                             |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-gitian, TorBrowserTeam201608R  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by mcs):

 Replying to [comment:16 boklm]:
 > ...
 > But there is still a good chance we will forget to update this. Maybe we
 can raise an error if the year used in the script and the year of the Tor
 Browser commit are different, so we don't forget to update it?

 This seems like a good idea, but if gk and you think it is sufficient to
 document this as part of our build procedures then just adding a mention
 there seems OK to me.

 > > * We should carry the build id through to update_responses so that the
 update manifests include the correct build ID.
 >
 > I pushed a new branch `bug_19528-v3` doing that:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 bundle.git/commit/?h=bug_19528-v3

 r=brade, r=mcs
 We did not run a test build, but the changes look good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19528#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online