[tor-bugs] #19872 [Core Tor/Tor]: Introduce prefixed sign/verify functions

[Tor Bug Tracker & Wiki]

#19872: Introduce prefixed sign/verify functions
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-proposed, tor-hs,                |  Actual Points:  0.3
  TorCoreTeam201608                              |
Parent ID:                                       |         Points:  0.3
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 The duplicate code in these two functions should be extracted into a
 static function.

 The test code should verify not only that "checksig" is the counterpart of
 "sign", but that "sign" produces the same output as if you had manually
 prefixed and signed the string.

 `make check-spaces` fails.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19872#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online