[tor-bugs] #19942 [Core Tor/Tor]: Fix mistake in comments in seccomp sandbox

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 19 05:29:52 UTC 2016


#19942: Fix mistake in comments in seccomp sandbox
------------------------------+-----------------
     Reporter:  cypherpunks   |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Low           |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Minor         |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------
 In src/common/sandbox.c, the comments for the sb_prctl() and sb_mprotect()
 functions both say they are for the fcntl64() syscall filter, probably
 because they were all copy pasted from that as a template.

 {{{
 --- src/common/sandbox.c
 +++ src/common/sandbox.c
 @@ -757,7 +757,7 @@
  }

  /**
 - * Function responsible for setting up the fcntl64 syscall for
 + * Function responsible for setting up the prctl syscall for
   * the seccomp filter sandbox.
   *
   * NOTE: if multiple filters need to be added, the PR_SECCOMP parameter
 needs
 @@ -778,7 +778,7 @@
  }

  /**
 - * Function responsible for setting up the fcntl64 syscall for
 + * Function responsible for setting up the mprotect syscall for
   * the seccomp filter sandbox.
   *
   * NOTE: does not NEED to be here.. currently only occurs before filter;
 will
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19942>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list