[tor-bugs] #15852 [Applications/Tor Browser]: Remove/synchronize Torbutton SOCKS pref logic

[Tor Bug Tracker & Wiki]

#15852: Remove/synchronize Torbutton SOCKS pref logic
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  brade
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-4.5-regression, tbb-torbutton-   |  Actual Points:
  conversion, TorBrowserTeam201608R              |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------
Changes (by mcs):

 * keywords:  tbb-4.5-regression, tbb-torbutton-conversion,
     TorBrowserTeam201608 => tbb-4.5-regression, tbb-torbutton-conversion,
     TorBrowserTeam201608R
 * status:  assigned => needs_review


Comment:

 Sometimes when you pull on a thread, an entire sweater begins to unravel.
 Kathy and I removed the code that dealt with the long gone proxy
 preferences, and that led us to to clean up more Torbutton code. The
 following branch contains 4 commits that are ready for review:
 https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug15852-01

 These commits can be smooshed together before merging into master, but it
 seemed better to keep them separate for review purposes.

 Please let us know if we removed something that should be kept. In our
 judgment, all of the code that we removed was either not being used or it
 could have confusing (and possible harmful) effects.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online