[tor-bugs] #19163 [Core Tor/Tor]: Make sure clients almost always use ntor

[Tor Bug Tracker & Wiki]

#19163: Make sure clients almost always use ntor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201608,     |  Actual Points:  5
  review-group-7                                 |
Parent ID:                                       |         Points:  2.0
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Testing this is difficult!

 I have merged two new chutney networks to chutney master, hs-min-mixed and
 basic-min-mixed. They are an even mix of old and new tor versions, and
 will likely fail if old and new versions do incompatible things. I've
 tested them with this patch and Tor 0.2.7.6.

 I also want to write unit tests for the cases where:
 * the service selects an intro point that's not in the client consensus,
 and
 * the client selects a rendezvous point that's not in the service
 consensus

 It is very hard to give a client and a relay different consensuses in
 chutney, so unit tests will have to do. Perhaps I should check code
 coverage first, so I know where to focus my efforts.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19163#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online