[tor-bugs] #19562 [Core Tor/Tor]: Implement a voting_schedule_free() function
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Aug 17 13:57:07 UTC 2016
#19562: Implement a voting_schedule_free() function
--------------------------+------------------------------
Reporter: dgoulet | Owner:
Type: enhancement | Status: merge_ready
Priority: Very Low | Milestone: Tor: 0.2.???
Component: Core Tor/Tor | Version:
Severity: Minor | Resolution:
Keywords: dirauth easy | Actual Points:
Parent ID: | Points: 0.1
Reviewer: dgoulet | Sponsor:
--------------------------+------------------------------
Changes (by dgoulet):
* status: needs_review => merge_ready
* reviewer: => dgoulet
Comment:
For a public function that is non-static, I personally prefer having the
object name before the action so `voting_schedule_free()` instead.
Actually, in this case if we really want to be strict on the namespacing,
we should do something like `dirvote_voting_schedule_free()` (or `dir_`)
but I'll leave this decision to nickm on what he prefers (as the
maintainer) :)
Apart from naming, lgtm!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19562#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list