[tor-bugs] #19163 [Core Tor/Tor]: Make sure clients almost always use ntor

[Tor Bug Tracker & Wiki]

#19163: Make sure clients almost always use ntor
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201608,     |  Actual Points:  5
  review-group-7                                 |
Parent ID:                                       |         Points:  2.0
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * keywords:  rsos, tor-hs, TorCoreTeam201607, review-group-7 => rsos, tor-
     hs, TorCoreTeam201608, review-group-7
 * points:  1.0 => 2.0


Comment:

 I've made an update based on nickm's review, and pushed it to github and
 gitlab.
 branch reject-tap-v5 on https://github.com/teor2345/tor.git
 https://gitlab.com/teor/tor/merge_requests/2

 I also folded the code from #19923 into this branch. I needed to add a
 stub for rend_service_allow_direct_connection to get it to compile.

 Sorry for the swapping back and forth.

 I still need to look at the test coverage of the changed lines, and do
 some more testing using mixed-version chutney networks, in particular:
 * basic-min (but with half/half old/new tor versions)
 * hs-min (but with half/half old/new tor versions)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19163#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online