[tor-bugs] #13953 [Core Tor/Tor]: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument

[Tor Bug Tracker & Wiki]

#13953: Self-test reachability test - Listen address from ORPort is ignored, it
uses default address unless specified via Address argument
-----------------------------------------------+---------------------------
 Reporter:  s7r                                |          Owner:  teor
     Type:  enhancement                        |         Status:
                                               |  needs_review
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:  Tor:
                                               |  0.2.5.10
 Severity:  Normal                             |     Resolution:
 Keywords:  review-group-7, TorCoreTeam201608  |  Actual Points:  1.0
Parent ID:  #17782                             |         Points:  3
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by teor):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:30 s7r]:
 > Nice to remove the duplicate code. I am happy with it, but I think we
 should reword the log message:
 >
 > '''''[...]If you have a static public IPv4 address, set 'Address
 <IPv4>'[...]'''''
 >
 > If there's just a static IP address, this setting is unnecessary, Tor
 will just discover and use it.

 No, that's not always true. Sometimes Tor's automatic address discovery
 fails, in particular, when it is not allowed to enumerate the IP addresses
 on the machine. Sometimes it works, but gets conflicting results (#17782,
 #17765).

  > The setting is necessary when there are multiple public IP addresses
 and the user wants to use a certain one.

 Yes, it's necessary in this case, but also necessary in other cases (which
 are somewhat unpredictable). So I'd rather log a message that encourages
 relay operators to set `Address` whenever they have a static IPv4, even if
 they sometimes don't need to, than have some relays stop working because
 `Address` wasn't set.

 > Also substitute IPv4 with IP, simpler and should cover IPv6 as well in
 the future.

 No, `Address` only takes an IPv4 address. The advertised IPv6 OR address
 is the address of the first IPv6 `ORPort`. It's not possible to use an
 IPv6 address with `Address`.

 > Latest branch that includes teor's refactoring and the reworded log
 message is `bug13953`on https://github.com/gits7r/tor.git

 You also added:
 `and 'OutboundBindAddress <IP>`

 I think it's ok to include it, as long as you're sure that pushing all Tor
 traffic through the relay IP is what most relay operators want. (I think
 it probably is.)

 I've merged that change in to:
 [bug13953 00557a5] fixup! fixup! fixup! fixup! Reword the
 router_check_descriptor_address_port_consistency log message
 on ​https://github.com/teor2345/tor.git

 I also tried to cut down the log message a bit more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13953#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online