[tor-bugs] #17178 [Core Tor/Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous

[Tor Bug Tracker & Wiki]

#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.2.9.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rsos, tor-hs, TorCoreTeam201608,     |  Actual Points:  10
  review-group-5, review-group-7                 |
Parent ID:  #19923                               |         Points:  6.5
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * parent:   => #19923
 * actualpoints:   => 10


Comment:

 I removed some code due to dgoulet's review.
 So the branch is now feature-17178-v6.

 The new commits start at:
 1a9d8a3 fixup! Single Onion Services retry a 3-hop path when rend is
 unreachable

 dgoulet wrote a review on:
 https://gitlab.com/teor/tor/merge_requests/3

 In response to dgoulet's review, I split off opportunistic ntor upgrades
 into #19923.
 There are a lot of dependencies, and I don't want to hold this feature up.

 asn wrote a review on:
 https://gitlab.com/asn/tor/merge_requests/2

 asn seemed to agree with dgoulet about the code in #19923 being too
 complex. Let's deal with it separately.

 In response to asn's review, I moved some Single Onion code into its own
 functions, refactored code so the logic was clearer, and added checks for
 single onion mode to functions that should only be called in that mode:
 [feature-17178-v6 84d0ec7] fixup! Implement Prop #260: Single Onion
 Services
 [feature-17178-v6 c72a46e] fixup! fixup! Implement Prop #260: Single Onion
 Services
 [feature-17178-v6 790d39c] fixup! fixup! fixup! Implement Prop #260:
 Single Onion Services

 The new gitlab merge request is at:
 https://gitlab.com/teor/tor/merge_requests/6

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:64>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online