[tor-bugs] #19820 [Core Tor/Tor]: Add deprecation facility, and deprecate some old options

[Tor Bug Tracker & Wiki]

#19820: Add deprecation facility, and deprecate some old options
-----------------------------------------------+---------------------------
 Reporter:  nickm                              |          Owner:  nickm
     Type:  defect                             |         Status:
                                               |  merge_ready
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.2.9.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  TorCoreTeam201608, review-group-7  |  Actual Points:  .5
Parent ID:                                     |         Points:  1
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 Only one question. Why aren't we calling `config_assign()` with the
 deprecation flag `CAL_WARN_DEPRECATIONS` if testing network is on? See
 `config.c +4966`. I guess we don't want to warn for testing but I think we
 should actually so anyone out there (and us) know what could be useless to
 test or about to die?

 Apart from that, this lgtm! Marking it `merge_ready`, leaving it to your
 discretion to change the above or not.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19820#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online