[tor-bugs] #13953 [Core Tor/Tor]: Self-test reachability test - Listen address from ORPort is ignored, it uses default address unless specified via Address argument

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 15 00:07:14 UTC 2016


#13953: Self-test reachability test - Listen address from ORPort is ignored, it
uses default address unless specified via Address argument
----------------------------+------------------------------------
 Reporter:  s7r             |          Owner:  teor
     Type:  enhancement     |         Status:  needs_revision
 Priority:  Medium          |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor    |        Version:  Tor: 0.2.5.10
 Severity:  Normal          |     Resolution:
 Keywords:  review-group-7  |  Actual Points:  0.5
Parent ID:  #17782          |         Points:  3
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * actualpoints:  3 hours => 0.5


Comment:

 Replying to [comment:24 s7r]:
 > On second thought, won't be possible to make this warning automatically
 go away with this simple logic:
 >
 > If the address explicitly configured with ORPort, if and only if, is a
 '''public IP address'''  - let's call this '''or-address''' (and it also
 matches the DirPort address?), Tor will automatically assume `Address ==
 or-address`, unless manually configured by user otherwise, and
 `OutboundBindAddress == or-address`, unless manually configured by user
 otherwise. This requires that the ORPort line to be used must not contain
 a `NoAdvertise` option. I think this could be a sane default, since it's
 clearly the intent of any user that specially configures an ORPort <public
 IP address>:<port> line in torrc.
 >
 > This will ensure:
 > 1. We are not breaking any existing torrcs.
 > 2. We avoid an additional warning in the log file which could confuse
 users who don't know so much about networking stuff.

 I was concerned about the possible negative impacts of this change to
 existing configurations, which is why I chose to just add a log message.
 And as nickm said in comment 17, if we want to modify Address guessing
 order, we should do it in the next release (see #19919).

 That said, I agree we could change the log message as suggested in comment
 23 to make it clearer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13953#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list