[tor-bugs] #19890 [Applications/Tor Browser]: Tor Browser warning: "Your Firefox is out of date."

[Tor Bug Tracker & Wiki]

#19890: Tor Browser warning: "Your Firefox is out of date."
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Critical                             |     Resolution:
 Keywords:  TorBrowserTeam201608,                |  Actual Points:
  tbb-6.0-issues                                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:7 cypherpunks]:
 > `extensions.systemAddon.update.url` should be set to "".

 I think this is a good solution. To check this, I found the location of
 the XPI in Tor Browser:
 {{{
 arthur at localhost ~/t/Browser> find . -name "*outofdate*"
 ./TorBrowser/Data/Browser/profile.default/features/{541bf4ef-2e8d-
 44d5-9aa1-887165d68eec}/outofdate-notifications at mozilla.org.xpi
 ./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864327100
 .72bc501f-cad6-4be7-b082-9af725197de9.outofdate-notifications-system-
 addon.jsonlz4
 ./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864333700.c7c02599-f462-49f2-8f11-fad83bfc976c
 .outofdate-notifications-system-addon.jsonlz4
 }}}
 After setting the pref to "", I opened Tor Browser and entered the
 following in the browser console:
 {{{
 Cu.import("resource://gre/modules/AddonManager.jsm");
 AddonManagerPrivate.backgroundUpdateCheck();
 }}}
 Then I confirmed that the XPI had been removed:
 {{{
 arthur at localhost ~/t/Browser> find . -name "*outofdate*"
 ./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864327100
 .72bc501f-cad6-4be7-b082-9af725197de9.outofdate-notifications-system-
 addon.jsonlz4
 ./TorBrowser/Data/Browser/profile.default/datareporting/archived/2016-08/1470864333700.c7c02599-f462-49f2-8f11-fad83bfc976c
 .outofdate-notifications-system-addon.jsonlz4
 }}}
 Here is the relevant code that apparently removes the XPI file. When the
 pref is empty, `url` is falsey and `yield
 systemAddonLocation.cleanDirectories();` is called:
 https://dxr.mozilla.org/mozilla-central/rev
 /0502bd9e025edde29777ba1de4280f9b52af4663/toolkit/mozapps/extensions/internal/XPIProvider.jsm#3069

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19890#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online