[tor-bugs] #19720 [Metrics/CollecTor]: CollecTor should be re-configurable without restart

[Tor Bug Tracker & Wiki]

#19720: CollecTor should be re-configurable without restart
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Hmmm hmmmm hmmm hmmm hmmmmmmmm.  In other words, I'm unclear what's best
 here.  I would like us to, at some point, re-evaluate how we're
 implementing configuration, logging, and possibly other things closely
 related to operation.  For example, a while ago it took me a moment to
 accept that CollecTor writes the default collector.properties if that file
 didn't exist; that was a bit too much magic for me, though I see the
 benefit.  I'm also not entirely happy with the way we're logging to
 LOGBASE_IS_UNDEFINED/ if the operator doesn't specify a directory, though
 I don't have a better idea how to do this right now.  And now I'm slightly
 concerned about the configuration file to be re-read without the operator
 explicitly asking CollecTor to do that (see my earlier comments before
 weasel chimed in).

 But I agree that we'll have to rethink these things anyway when we talk
 about providing (Debian) packages.  And I agree that having a way to
 reconfigure CollecTor while it's running is useful.  So, I suggest that
 I'll review the changes you posted and then merge them later today or
 early tomorrow.  And we create a ticket for a later milestone where we
 reconsider these design decisions about configuration, logging, etc.
 How's that?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19720#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online