[tor-bugs] #19830 [Metrics/CollecTor]: Check if recent directory exists before checking available space

[Tor Bug Tracker & Wiki]

#19830: Check if recent directory exists before checking available space
-----------------------------------+-----------------------------
     Reporter:  karsten            |      Owner:
         Type:  defect             |     Status:  new
     Priority:  Low                |  Milestone:  CollecTor 1.0.0
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+-----------------------------
 Today this exception was thrown at me by a fresh CollecTor instance:

 {{{
 2016-08-04 12:28:16,067 WARN o.t.c.c.CollecTorMain:75 Cannot access
 out/recent; reason: out/recent
 java.nio.file.NoSuchFileException: out/recent
         at
 sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
 ~[na:1.8.0_102]
         at
 sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
 ~[na:1.8.0_102]
         at
 sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
 ~[na:1.8.0_102]
         at sun.nio.fs.UnixFileStore.devFor(UnixFileStore.java:57)
 ~[na:1.8.0_102]
         at sun.nio.fs.UnixFileStore.<init>(UnixFileStore.java:64)
 ~[na:1.8.0_102]
         at sun.nio.fs.BsdFileStore.<init>(BsdFileStore.java:40)
 ~[na:1.8.0_102]
         at
 sun.nio.fs.BsdFileSystemProvider.getFileStore(BsdFileSystemProvider.java:46)
 ~[na:1.8.0_102]
         at
 sun.nio.fs.BsdFileSystemProvider.getFileStore(BsdFileSystemProvider.java:34)
 ~[na:1.8.0_102]
         at
 sun.nio.fs.UnixFileSystemProvider.getFileStore(UnixFileSystemProvider.java:368)
 ~[na:1.8.0_102]
         at java.nio.file.Files.getFileStore(Files.java:1461)
 ~[na:1.8.0_102]
         at
 org.torproject.collector.cron.CollecTorMain.checkAvailableSpace(CollecTorMain.java:66)
 [collector-0.9.0-dev.jar:0.9.0-dev-f2d0cf0]
         at
 org.torproject.collector.relaydescs.ArchiveWriter.startProcessing(ArchiveWriter.java:121)
 [collector-0.9.0-dev.jar:0.9.0-dev-f2d0cf0]
         at
 org.torproject.collector.cron.CollecTorMain.run(CollecTorMain.java:42)
 [collector-0.9.0-dev.jar:0.9.0-dev-f2d0cf0]
         at
 java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
 [na:1.8.0_102]
         at
 java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
 [na:1.8.0_102]
         at
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
 [na:1.8.0_102]
         at
 java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
 [na:1.8.0_102]
         at
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
 [na:1.8.0_102]
         at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
 [na:1.8.0_102]
         at java.lang.Thread.run(Thread.java:745) [na:1.8.0_102]
 }}}

 Looks like a trivial bug in #18865.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19830>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online