[tor-bugs] #19776 [Metrics/CollecTor]: Make minor improvements to scheduler

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 1 12:23:55 UTC 2016


#19776: Make minor improvements to scheduler
-------------------------------+---------------------------------
 Reporter:  karsten            |          Owner:  iwakeh
     Type:  enhancement        |         Status:  assigned
 Priority:  Medium             |      Milestone:  CollecTor 1.0.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):

 * status:  new => assigned
 * owner:   => iwakeh


Comment:

 Replying to [ticket:19776 karsten]:
 > While running some local performance tests of the bridge descriptor
 sanitizer I noticed a few possible improvements:
 >
 >  - I noticed that the default configuration changed some paths, like,
 move multiple directories under `out/`.  Can we undo that change, so that
 CollecTor uses the exact same paths in the new default configuration as
 previously?

 Well, I thought because of
 [https://trac.torproject.org/projects/tor/ticket/19424#comment:6 comment6]
 these were already corrected to the paths use in the main CollecTor
 instance.
 Please adjust these paths with the sanitizer ticket.  My CollecTor
 instance was configured differently from the beginning and I would have to
 guess everything.

 >
 >  - The `recent/` directory is not truly configurable.  I can change that
 along with the other bugfixes to the bridge descriptor sanitizer, if you
 want.
 >

 Planned this for the upcoming implementation of #19720.  But it might
 better fit into the sanitizer fixes.

 >  - It seems like the scheduler calculates how many minutes it needs to
 sleep from the current system time to start the next run with `x` minutes
 offset from the period of `y` minutes.  Example: system time is
 20:43:15.123, period is 60 minutes, offset is 44 minutes, the scheduler
 will start the next run at 20:44:15.123, but really it should start it at
 20:44:00.000.

 A feature not a bug :-) As the time resolution is minutes the start second
 shouldn't matter.
 But it makes sense to change this the way you suggested.  I'll look into
 it.

 >
 >  - Can we add a mode to run a given module immediately, skipping the
 scheduler entirely?  That would be quite useful for testing, batch-
 processing, and maybe other purposes.  Onionoo has such a mode with
 `--single-run` (or however it's called).  But please don't break the
 design too much to make this work, if it's too ugly, skip this.

 I'll take a look at this, too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19776#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list