[tor-bugs] #19755 [Metrics/CollecTor]: improve code quality of bridgedescs module
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Aug 1 09:01:35 UTC 2016
#19755: improve code quality of bridgedescs module
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: CollecTor 1.1.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Comment (by iwakeh):
> > And, some helper classes instead of private inner classes
TarballBuilder and the different *DescriptorBuilders would make the test
class a little shorter.
>
> Not so sure about this one. The advantage of making them inner classes
is that they can access the outer classes' attributes. Making them
separate classes would lead to even more code overall. But let's see how
things evolve.
The only attribute used seems [https://gitweb.torproject.org/karsten
/metrics-
db.git/tree/src/test/java/org/torproject/collector/bridgedescs/SanitizedBridgesWriterTest.java?h=task-19755&id=1c6af44d2500bd0f1ec6538a66ad1b4fb860db19#n145
bridgeDirectoriesDir], I think.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19755#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list