[tor-bugs] #18933 [Core Tor/Tor]: Several problems with test-network Makefile target

[Tor Bug Tracker & Wiki]

#18933: Several problems with test-network Makefile target
-------------------------------+------------------------------------
 Reporter:  isis               |          Owner:  isis
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Core Tor/Tor       |        Version:  Tor: 0.2.8.2-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  TorCoreTeam201605  |  Actual Points:
Parent ID:                     |         Points:  small
 Reviewer:                     |        Sponsor:  SponsorS
-------------------------------+------------------------------------

Comment (by cypherpunks):

 Replying to [comment:4 isis]:
 > Replying to [comment:3 cypherpunks]:
 > > The second problem is addressed in #18737 but is waiting for #18240 to
 be merged. Depending on whether coverage is enabled, the *-cov binaries
 may or may not be available. After the merge of #18240 i plan on adding a
 fixup patch that adds a variable for tor-gencert (like
 `TESTING_TOR_BINARY`) so the dependencies of the test-network target are
 dynamic. I'm waiting for the merge because the changes are overlapping and
 would lead to merge conflicts.
 >
 > Great! That fixes all of it except for the `$(EXEEXT)` problem for the
 `tor-[cov-]gencert` binary.
 I can think of only one clean way to communicate the `$(EXEEXT)` to the
 script and that is with parameters (similar to Stem's `run-tests.py` (see
 test-stem target)). The added benefit would be that it simplifies test-
 network.sh because it would just use the binaries as is which obsoletes
 the tor-path and coverage options.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18933#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online