[tor-bugs] #18928 [Applications/Tor Browser]: Mac OS: alpha channel upgrade is not smooth

[Tor Bug Tracker & Wiki]

#18928: Mac OS: alpha channel upgrade is not smooth
--------------------------------------------+--------------------------
 Reporter:  mcs                             |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  High                            |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff45-esr, TorBrowserTeam201604  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------
Changes (by brade):

 * cc: boklm (added)
 * keywords:  TorBrowserTeam201604 => ff45-esr, TorBrowserTeam201604


Comment:

 Before restart, XRE_PROFILE_PATH is set to the profile path. See:
 http://mxr.mozilla.org/mozilla-
 esr45/source/toolkit/xre/nsAppRunner.cpp#4419

 This causes the SelectProfile() function to use that profile (and
 therefore our migration code never gets a chance to run). See:
 http://mxr.mozilla.org/mozilla-
 esr45/source/toolkit/xre/nsAppRunner.cpp#2333

 The right fix is probably to ignore the XRE_PROFILE_PATH env variable if
 it contains the path of the old default profile location
 (.../TorBrowser.app/TorBrowser/Data/Browser/profile.default).

 gk or boklm: We should add something to the TB 6.0a5 blog post to let
 people know to expect this problem (they should quit and start TB again to
 fix things).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18928#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online