[tor-bugs] #18921 [Core Tor/Tor]: Fix IPv6 bridge client directory address selection

[Tor Bug Tracker & Wiki]

#18921: Fix IPv6 bridge client directory address selection
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.8.x-final
 Keywords:  must-fix-before-028-rc               |        Version:  Tor:
  TorCoreTeam201604                              |  0.2.8.1-alpha
Parent ID:  #18483                               |     Resolution:
 Reviewer:  isis                                 |  Actual Points:  1 hour
                                                 |         Points:  small
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 isis correctly points out that I have DIRIND_ANONYMOUS connections always
 using IPv4 addresses. This won't work for IPv6 bridges.

 I should use node_get_pref_orport() to get the canonical address of the
 node that we'll use to connect to it as a guard. This correctly uses IPv6
 when it's available and preferred (including when bridge clients only have
 an IPv6 address), and IPv4 otherwise.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18921#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online