[tor-bugs] #18931 [Metrics/CollecTor]: coding style polishing

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 29 08:12:09 UTC 2016


#18931: coding style polishing
-----------------------------------+--------------------
     Reporter:  iwakeh             |      Owner:  iwakeh
         Type:  task               |     Status:  new
     Priority:  Medium             |  Milestone:
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:  ctip
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+--------------------
 Remove most checkstyle complaints:

 Priority wishlist:
 1. Each variable declaration must be in its own statement.
 [MultipleVariableDeclarations], b/c this really enhances readability and
 could trip some IDEs when refactoring variable names.
 1. '<operator>' should be on a new line. [OperatorWrap]
 1. Missing a Javadoc comment. [JavadocMethod]
 1. others

 It still needs to be verified, if our exceptions from Google-style are
 reflected in the checks. If not, metrics_checks.xml has to be changed
 accordingly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18931>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list