[tor-bugs] #18928 [Applications/Tor Browser]: Mac OS: alpha channel upgrade is not smooth

[Tor Bug Tracker & Wiki]

#18928: Mac OS: alpha channel upgrade is not smooth
--------------------------------------+--------------------------
 Reporter:  mcs                       |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by mcs):

 During the failed startup, a TorBrowser-Data directory is created but it
 is nearly empty:
 {{{
 TorBrowser-Data/
   Browser/
     Caches/
 }}}
 My current guess at what is happening: the restart-after-update passes the
 location of the old profile via an env var (which causes it to be used
 when we do not want it to be), and that env var is cleared before the
 second restart (which causes a new profile to be created and our profile
 migration code to be executed).

 I know we tested this, but maybe not correctly and probably not with an
 ESR45-based browser.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18928#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online