[tor-bugs] #18915 [Applications/Tor Browser]: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine in 6.0a5

[Tor Bug Tracker & Wiki]

#18915: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine
in 6.0a5
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  defect                               |         Status:
 Priority:  Very High                            |  assigned
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Critical                             |        Version:
 Keywords:  ff45-esr, GeorgKoppen201604          |     Resolution:
  TorBrowserTeam201604                           |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Thanks to fqueze for debugging help! It seems that
 https://bugzilla.mozilla.org/show_bug.cgi?id=1162569 is the likely
 culprit.

 We have a bunch of options here

 1) We override `resource://search-plugins/` to point to a custom location
 2) We ship our search plugins in a distribution folder
 3) We replace the lang pack search engines and list.txt with the ones we
 want to get used during the bundling step.

 I think I prefer 3) for at least two reasons: a) We can be sure that only
 our plugins get shipped. No other code path can use search plugins we
 don't want to get used. b) we avoid another possible Tor Browser patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18915#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online