[tor-bugs] #18915 [Applications/Tor Browser]: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine in 6.0a5
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Apr 28 08:57:22 UTC 2016
#18915: Omnibox in a non-english Tor Browser has no Disconnect.me as search engine
in 6.0a5
-------------------------------------------------+-------------------------
Reporter: gk | Owner: gk
Type: defect | Status:
Priority: Very High | assigned
Component: Applications/Tor Browser | Milestone:
Severity: Critical | Version:
Keywords: ff45-esr, GeorgKoppen201604 | Resolution:
TorBrowserTeam201604 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by arthuredelstein):
I noticed that in our [https://gitweb.torproject.org/tor-
browser.git/commit/?h=tor-
browser-38.8.0esr-5.5-1&id=84d99d3ae559ee28360c80dd768b684911998a6a
"Omnibox patch"] we add various *.xml files (search engine definitions) to
the directory `browser/locales/en-US/searchplugins/`. So it would seem
that this patch is specifically adding search engines for the US English
locale only. I'm not sure why this approach would have provided the
correct search engines in non-English in TBB/ESR38, but it at least seems
like a plausible explanation for the problem we see in TBB/ESR45.
There's another directory, `browser/locales/generic/`, that at least
superficially looks like it may provide its contents to every locale. So I
added a matching `searchplugins` directory and added disconnect.xml and
youtube.xml therein. I'm currently building the full tor-browser-
bundle.git with this change, and I'll report the results soon.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18915#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list