[tor-bugs] #18918 [Core Tor/Tor]: Clarify directory and ORPort checking functions

[Tor Bug Tracker & Wiki]

#18918: Clarify directory and ORPort checking functions
------------------------------+------------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.???
    Component:  Core Tor/Tor  |    Version:  Tor: 0.2.8.1-alpha
     Severity:  Normal        |   Keywords:  easy doc code refactor
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------------
 The OR and dir checking functions in router.c are somewhat confusing. We
 could document them better, or modify their names, or restructure.

 In #18616, we added:
 * decide_to_advertise_begindir

 We already had:
 * check_whether_orport_reachable
 * check_whether_dirport_reachable
 * router_has_bandwidth_to_be_dirserver
 * router_should_be_directory_server
 * dir_server_mode
 * decide_to_advertise_dirport
 * consider_testing_reachability

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18918>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online