[tor-bugs] #18710 [Core Tor/Tor]: dnsserv.c asserts when no supported questions are requested

[Tor Bug Tracker & Wiki]

#18710: dnsserv.c asserts when no supported questions are requested
-------------------------------------------------+-------------------------
 Reporter:  geekmug                              |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_revision
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.???
 Keywords:  dns dnsport tor-client 029-proposed  |        Version:  Tor:
Parent ID:                                       |  0.2.7.6
 Reviewer:  nickm                                |     Resolution:
                                                 |  Actual Points:
                                                 |         Points:  very
                                                 |  small
                                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:  dns dnsport tor-client 027-backport TorCoreTeam201604 => dns
     dnsport tor-client 029-proposed
 * status:  needs_review => needs_revision
 * priority:  Very High => Medium
 * points:   => very small
 * milestone:  Tor: 0.2.8.x-final => Tor: 0.2.???


Comment:

 I've tested Tor 0.2.5 and forward with MX queries to verify that they
 don't actually crash.  It appears they don't. I'm testing by only sending
 a single MX query in the request.

 (Please correct me if I'm wrong!)

 Assuming that there isn't _really_ a crash bug, this is just ugly code,
 nothing more. So it can be a cleanup fix for 0.2.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18710#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online