[tor-bugs] #18852 [Core Tor/Tor]: Directory mirrors should check accounting usage more frequently

[Tor Bug Tracker & Wiki]

#18852: Directory mirrors should check accounting usage more frequently
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:
     Type:  defect                  |         Status:  new
 Priority:  Medium                  |      Milestone:  Tor: 0.2.8.x-final
Component:  Core Tor/Tor            |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal                  |     Resolution:
 Keywords:  must-fix-before-028-rc  |  Actual Points:
Parent ID:  #18616                  |         Points:
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------
Description changed by nickm:

Old description:

> After merging #12358 and #18616, Tor can wait up to 18 hours before
> checking whether the accounting usage has increase so much that we want
> to stop advertising DirPort and begindir support.
>
> This is not great for relays with daily accounting periods.
>
> I suggest we check every hour to see whether the result of
> router_should_be_directory_server() has changed. If so, we should
> mark_my_descriptor_dirty() with an appropriate message about deciding to
> advertise or stop advertising directory service support / DirPort.
>
> This likely also means separating the calculation part of
> router_should_be_directory_server() from the logging, otherwise we will
> log duplicate messages each time we change our minds about our
> accounting.

New description:

 After merging #12538 and #18616, Tor can wait up to 18 hours before
 checking whether the accounting usage has increase so much that we want to
 stop advertising DirPort and begindir support.

 This is not great for relays with daily accounting periods.

 I suggest we check every hour to see whether the result of
 router_should_be_directory_server() has changed. If so, we should
 mark_my_descriptor_dirty() with an appropriate message about deciding to
 advertise or stop advertising directory service support / DirPort.

 This likely also means separating the calculation part of
 router_should_be_directory_server() from the logging, otherwise we will
 log duplicate messages each time we change our minds about our accounting.

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18852#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online