[tor-bugs] #18897 [Core Tor/Tor]: Narrow scan-build checkers to those that have an acceptably low false positive rate.

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 26 16:18:00 UTC 2016


#18897: Narrow scan-build checkers to those that have an acceptably low false
positive rate.
--------------------------+------------------------------
 Reporter:  nickm         |          Owner:
     Type:  enhancement   |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  029-proposed  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  SponsorS-can
--------------------------+------------------------------

Comment (by teor):

 Replying to [comment:2 teor]:
 > Tor passes the standard OS X Xcode "Deep Analyze" clang scan-build
 checks, or at least it did when I last ran them on an 0.2.8-alpha.

 No, it's become smarter!

 There are about 100 spurious "value stored is never read" warnings that
 appear to be good defensive programming practice. We should turn this type
 of warning off.

 There's also a spurious "garbage data" warning in
 ge25519_scalarmult_base_niels because clang can't tell the size of a char
 * containing key data. I tried to eliminate this in 0.2.8(?), but clang
 got smarter and found it again. Not sure what to do about this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18897#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list