[tor-bugs] #17799 [Core Tor/Tor]: Hash All PRNG output before use
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Apr 26 12:37:15 UTC 2016
#17799: Hash All PRNG output before use
-------------------------------+----------------------------------------
Reporter: teor | Owner: nickm
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor | Version: Tor: unspecified
Severity: Normal | Resolution:
Keywords: TorCoreTeam201604 | Actual Points:
Parent ID: | Points: small/medium-remaining
Reviewer: asn | Sponsor:
-------------------------------+----------------------------------------
Comment (by nickm):
> maybe we could rename the variables
Fair point; done.
> As another question, why do we use mmap() to allocate space for the
shake_prng_t?
We're using mmap to ensure that we get our own page. If we have our own
page, we can use madvise and mlock (and eventually mprotect and minherit
as needed) on it, whereas if we use malloc, we'll be sharing the page with
other parts of the heap. Expanded the comment a little there.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17799#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list