[tor-bugs] #18741 [Applications/Tor Browser]: OCSP and favicon isolation is only partly working in ESR 45

[Tor Bug Tracker & Wiki]

#18741: OCSP and favicon isolation is only partly working in ESR 45
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  High                                 |         Status:  closed
Component:  Applications/Tor Browser             |      Milestone:
 Severity:  Major                                |        Version:
 Keywords:  ff45-esr, tbb-6.0a5,                 |     Resolution:  fixed
  TorBrowserTeam201604R                          |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:13 arthuredelstein]:
 > Replying to [comment:12 mcs]:
 > > Replying to [comment:11 gk]:
 > > > [snip]
 > > > Sounds like a good approach we could test in the alpha. One nit:
 > > >
 > > > There is no need for an additional `node->IsElement()` check as you
 are landing in the `if`-block only after the `node->IsElement()` check
 passes.
 > >
 > > Yes, r=brade and r=mcs if you remove the extra IsElement() check.
 >
 > Here's the new branch with this nit fixed. I am currently running a
 3-platform build and will also run mochitests on linux when it's ready. I
 have already run the mochitest on OS X and it all passes.

 Sounds good to me. Let me know if anything breaks. Otherwise I am closing
 this and putting this in the alpha to get the build going. This is fixed
 in commit 1f16ce85bc145032a6954a2b8ae81875c6ec1dbf,
 9c9b94f764495c8500093622c611029883badc97 and
 e6b06c64d7a2294a0f3def31d8e51acd751f40c9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18741#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online