[tor-bugs] #13239 [Core Tor/Tor]: Maybe we want three preemptive internal circs for hidden services?

[Tor Bug Tracker & Wiki]

#13239: Maybe we want three preemptive internal circs for hidden services?
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
     Type:  defect                               |         Status:
 Priority:  Medium                               |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  tor-client, tor-hs,                  |        Version:
  TorCoreTeam201604                              |     Resolution:
Parent ID:  #5271                                |  Actual Points:
 Reviewer:  asn                                  |         Points:  small
                                                 |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:15 dgoulet]:
 > Ok, to move this one forward, here is the _minimal_ fix suggested.
 Please make sure that this one liner is correct because there are two
 "need_uptime" thingy...
 >
 > See branch: `bug13239_029_01`
 >
 > Thought: what sysrqb did here is imo useful that is move hardcoded
 values to defines and improve code flow. Maybe we should open a ticket for
 "let's refactor/improve circuit_predict_and_launch_new()" for which what
 sysrqb did is not lost?

 Your patch `bug13239_029_01` looks good to me. It also seems to agree with
 sysrqb's patch in terms of the parameter changed.

 I also created a ticket for refactoring the function entirely at #18873. I
 filed it under `Tor: 0.2.??` because I was not sure what milestone to file
 it under.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13239#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online