[tor-bugs] #15621 [Core Tor/Tor]: Kill the pre-version 3 intro protocol code with fire.

[Tor Bug Tracker & Wiki]

#15621: Kill the pre-version 3 intro protocol code with fire.
---------------------------------------+-----------------------------------
 Reporter:  yawning                    |          Owner:  dgoulet
     Type:  enhancement                |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
Component:  Core Tor/Tor               |  0.2.9.x-final
 Severity:  Normal                     |        Version:
 Keywords:  tor-hs, TorCoreTeam201604  |     Resolution:
Parent ID:  #6418                      |  Actual Points:
 Reviewer:  asn                        |         Points:  small
                                       |        Sponsor:  SponsorR-can
---------------------------------------+-----------------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 * NM1: I don't like the looks of the hardcoded `(1<<3)` refereneces; can
 these become a macro or move into a `hs_protocols_supported()` function or
 something? Similarly the "if version != 3" one.
  * NM2: Should the union in rend_intro_cell_s go away? Unions can be
 scary.  This could be another ticket.
  * NM3: err_msg_out isn't used in rend_service_parse_intro_unsupported.
 Should it be?  There's probably *some* message to give there, right?
  * NM4: I am concerned about fingerprinting attacks here. Do we have a
 good story about fingerprinting hidden services and their users as they
 upgrade, and why that will/won't matter?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15621#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online