[tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file

[Tor Bug Tracker & Wiki]

#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
-----------------------------------------------+---------------------------
 Reporter:  propropus                          |          Owner:
     Type:  defect                             |         Status:
 Priority:  High                               |  needs_information
Component:  Tor                                |      Milestone:  Tor:
 Severity:  Major                              |  0.2.8.x-final
 Keywords:  WarnUnsafeSocks, Log 027-backport  |        Version:
Parent ID:                                     |     Resolution:
 Reviewer:                                     |  Actual Points:
                                               |         Points:
                                               |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by cypherpunks):

 Replying to [comment:9 arma]:
 > Replying to [comment:4 cypherpunks]:
 > > Seems like the condition should be removed completely.
 >
 > I'm not yet convinced.

 Ok, but how is '''not''' removing the condition going to help then? If you
 remove the condition then you '''will''' get the warning, unless of course
 you're over the rate-limiting threshold.

 To fully regain the semantics before Nick's patch, it is necessary to
 disable the rate-limiting, now part of the logging function itself, in the
 case of `safe_socks` being true. Depending on the implementation, a
 similar condition might be necessary. Is this what you are trying to get
 to?

 Or am I misremembering the code that badly?

 (I don't yet understand your second paragraph.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online