[tor-bugs] #18213 [Tor]: The parameter WarnUnsafeSocks does not work as specified in the documentation, no warning is logged in the log file

[Tor Bug Tracker & Wiki]

#18213: The parameter WarnUnsafeSocks does not work as specified in the
documentation, no warning is logged in the log file
-----------------------------------------------+---------------------------
 Reporter:  propropus                          |          Owner:
     Type:  defect                             |         Status:
 Priority:  High                               |  needs_information
Component:  Tor                                |      Milestone:  Tor:
 Severity:  Major                              |  0.2.8.x-final
 Keywords:  WarnUnsafeSocks, Log 027-backport  |        Version:
Parent ID:                                     |     Resolution:
 Reviewer:                                     |  Actual Points:
                                               |         Points:
                                               |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by arma):

 Replying to [comment:4 cypherpunks]:
 > Seems like the condition should be removed completely.

 I'm not yet convinced. The original goal was to warn every single time we
 had an unsafe connection, when SafeSocks is on. That way you don't end up
 in a situation where you do a thing, check your log, see no complaints,
 and decide that the thing was ok to do.

 There's a bigger issue here though. We have a
 {{{log_unsafe_socks_warning}}} parameter in the parent function, which is
 set by the TestSocks config option, and that parameter isn't making its
 way to this log_unsafe_socks_warning() function. Yuck.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18213#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online