[tor-bugs] #18809 [Tor]: Handle linked connections better during bootstrap

[Tor Bug Tracker & Wiki]

#18809: Handle linked connections better during bootstrap
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:
     Type:  defect                  |         Status:  needs_review
 Priority:  Medium                  |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor                     |        Version:  Tor: 0.2.8.1-alpha
 Severity:  Normal                  |     Resolution:
 Keywords:  must-fix-before-028-rc  |  Actual Points:
Parent ID:                          |         Points:
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------
Changes (by arma):

 * status:  new => needs_review


Comment:

 Ok, my bug18809 branch is ready for review.

 I tested it in a variety of ways, and it seems to work as intended.

 I left the unit tests a broken mess though. :/ If we like the changes
 here, we can clean up the unit tests.

 My next trick is going to be locking down all the situations where clients
 that ought to be doing begindirs might instead end up doing a naked
 dirport connection (e.g. #18483). I think each of those cases is a mistake
 and we should fix it. The reason I want to do it here is because now #4483
 plus this branch likely has some edge cases where we could open naked
 dirport consensus fetches in parallel, and not notice to cancel them. I
 would rather fix that bug at the root rather than complicate this patch
 with it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18809#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online