[tor-bugs] #18808 [Tor]: Check if connection is excess in connection_dir_finished_flushing

[Tor Bug Tracker & Wiki]

#18808: Check if connection is excess in connection_dir_finished_flushing
------------------------+------------------------------------
     Reporter:  teor    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  Medium  |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor     |    Version:  Tor: 0.2.8.1-alpha
     Severity:  Normal  |   Keywords:  must-fix-before-028-rc
Actual Points:          |  Parent ID:
       Points:          |   Reviewer:
      Sponsor:          |
------------------------+------------------------------------
 In #4483, I added a check like the one below to every transition from
 DIR_CONN_STATE_CONNECTING to another state, but I missed
 connection_dir_finished_flushing:

 {{{
         /* Close this connection if there's another consensus connection
          * downloading (during bootstrap), or connecting (after
 bootstrap). */
         if (connection_dir_close_consensus_conn_if_extra(conn)) {
           return;
         }
 }}}

 It would be good to to fix this in 0.2.8, because otherwise clients could
 end up requesting multiple consensuses, which is expensive for relays and
 for the network.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18808>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online