[tor-bugs] #18765 [Tor]: strlcat

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 8 09:03:55 UTC 2016


#18765: strlcat
-------------------------+---------------------
 Reporter:  cypherpunks  |          Owner:
     Type:  defect       |         Status:  new
 Priority:  Medium       |      Milestone:
Component:  Tor          |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+---------------------

Comment (by cypherpunks):

 Different cypherpunk here. The submitted patch corresponds to the change
 between 1.13 and 1.14 (http://cvsweb.openbsd.org/cgi-
 bin/cvsweb/src/lib/libc/string/strlcat.c.diff?r1=1.13&r2=1.14&f=h) but
 misses the change above that line with changes
 {{{
 if (n == 0)
 }}}
 to
 {{{
 if (n-- == 0)
 }}}

 I'm suggesting to simply replace the file with the newest version
 available from OpenBSD (http://cvsweb.openbsd.org/cgi-
 bin/cvsweb/src/lib/libc/string/strlcat.c) because it has been improved
 since Tor included it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18765#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list