[tor-bugs] #16873 [metrics-lib]: add javadoc to metrics-lib

[Tor Bug Tracker & Wiki]

#16873: add javadoc to metrics-lib
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  karsten
     Type:  enhancement  |         Status:  needs_review
 Priority:  Low          |      Milestone:
Component:  metrics-lib  |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by iwakeh):

 This looks great!

 I have some very minor additions:

 For getSocksPort() near
 [https://trac.torproject.org/projects/tor/attachment/ticket/16873/ServerDescriptor.java#L33
 line 33]:
 Maybe, add that 0 is returned because SOCKSPort is deprecated. Otherwise,
 it might seem odd to someone unfamiliar with the descriptor format.

 Maybe add a link to the respective extra info methods to getReadHistory()
 and getWriteHistory() near
 [https://trac.torproject.org/projects/tor/attachment/ticket/16873/ServerDescriptor.java#L124
 line 124] and
 [https://trac.torproject.org/projects/tor/attachment/ticket/16873/ServerDescriptor.java#L130
 line 130]?

 And the copyright year could be increased to 2016?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16873#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online