[tor-bugs] #15197 [Tor Browser]: Rebase Tor Browser patches to ESR 45

[Tor Bug Tracker & Wiki]

#15197: Rebase Tor Browser patches to ESR 45
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
     Type:  task                                 |  arthuredelstein
 Priority:  Very High                            |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Critical                             |      Milestone:
 Keywords:  ff45-esr, TorBrowserTeam201604,      |        Version:
  tbb-6.0a5                                      |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:25 gk]:
 > How can I reproduce that one? Allowing canvas on e.g. github.com works
 fine for me on a 64bit Linux box.

 Looking a little more closely, this probably only occurs in debug builds
 (assertion failure). Here is a partial call stack (Mac OS debug build):
 {{{
 Assertion failure: !mIsMapped (Someone forgot to call Unmap()), at
 /Users/brade/dev/tor/tor-browser-arthur/gfx/2d/2D.h:383
 #01:
 mozilla::gfx::DataSourceSurface::~DataSourceSurface()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x1412e1d]
 #02:
 mozilla::gfx::DataSourceSurfaceWrapper::~DataSourceSurfaceWrapper()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x1412db1]
 #03:
 mozilla::gfx::DataSourceSurfaceWrapper::~DataSourceSurfaceWrapper()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x1412bf5]
 #04:
 mozilla::gfx::DataSourceSurfaceWrapper::~DataSourceSurfaceWrapper()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x1412c19]
 #05: mozilla::detail::RefCounted<mozilla::gfx::SourceSurface,
 (mozilla::detail::RefCountAtomicity)1>::Release()
 const[/Users/brade/Desktop/tb-esr45/tb-esr45.app/Contents/MacOS/XUL
 +0x13b223a]
 #06:
 RefPtr<mozilla::gfx::DataSourceSurface>::AddRefTraitsReleaseHelper(mozilla::gfx::DataSourceSurface*)[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x13b211c]
 #07:
 RefPtr<mozilla::gfx::DataSourceSurface>::AddRefTraits<mozilla::gfx::DataSourceSurface>::Release(mozilla::gfx::DataSourceSurface*)[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x13b20f5]
 #08:
 RefPtr<mozilla::gfx::DataSourceSurface>::~RefPtr()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x13b22fd]
 #09:
 RefPtr<mozilla::gfx::DataSourceSurface>::~RefPtr()[/Users/brade/Desktop
 /tb-esr45/tb-esr45.app/Contents/MacOS/XUL +0x13b1e15]
 #10: mozilla::dom::CanvasRenderingContext2D::GetImageDataArray(JSContext*,
 int, int, unsigned int, unsigned int, JSObject**)[/Users/brade/Desktop/tb-
 esr45/tb-esr45.app/Contents/MacOS/XUL +0x2c2021a]
 #11: mozilla::dom::CanvasRenderingContext2D::GetImageData(JSContext*,
 double, double, double, double,
 mozilla::ErrorResult&)[/Users/brade/Desktop/tb-esr45/tb-
 esr45.app/Contents/MacOS/XUL +0x2c1f581]
 #12:
 mozilla::dom::CanvasRenderingContext2DBinding::getImageData(JSContext*,
 JS::Handle<JSObject*>, mozilla::dom::CanvasRenderingContext2D*,
 JSJitMethodCallArgs const&)[/Users/brade/Desktop/tb-esr45/tb-
 esr45.app/Contents/MacOS/XUL +0x23f686f]
 [snip]
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15197#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online