[tor-bugs] #18686 [Tor]: tor port forwarding claims to kill long-dead forwarder

[Tor Bug Tracker & Wiki]

#18686: tor port forwarding claims to kill long-dead forwarder
------------------------+------------------------------------
 Reporter:  chadmiller  |          Owner:
     Type:  defect      |         Status:  needs_review
 Priority:  Medium      |      Milestone:  Tor: 0.2.8.x-final
Component:  Tor         |        Version:  Tor: 0.2.7.6
 Severity:  Major       |     Resolution:
 Keywords:              |  Actual Points:
Parent ID:              |         Points:
 Reviewer:              |        Sponsor:
------------------------+------------------------------------

Comment (by nickm):

 Would this patch be sufficient?

 {{{
 diff --git a/src/common/util.c b/src/common/util.c
 index 2351faf5036e44..b932d7310f97de 100644
 --- a/src/common/util.c
 +++ b/src/common/util.c
 @@ -3949,7 +3949,7 @@ tor_terminate_process(process_handle_t
 *process_handle)
    }
  #endif

 -  return -1;
 +  return 0; /* We decided not to kill the process, so report success. */
  }

  /** Return the Process ID of <b>process_handle</b>. */
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18686#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online