[tor-bugs] #17173 [Tor]: Bug: tor_addr_is_internal() called from src/common/address.c:1646 with a non-IP address of type 49 (on Tor 0.2.7.3-rc 9a4cac74fd2f4bb3)

Mon Sep 28 15:53:51 UTC 2015

#17173: Bug: tor_addr_is_internal() called from src/common/address.c:1646 with a
non-IP address of type 49 (on Tor 0.2.7.3-rc 9a4cac74fd2f4bb3)
------------------------+--------------------------------
     Reporter:  fk      |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor     |    Version:  Tor: 0.2.7.3-rc
   Resolution:          |   Keywords:  regression
Actual Points:          |  Parent ID:
       Points:          |    Sponsor:
------------------------+--------------------------------

Comment (by fk):

 That suspicion didn't pan out. I'm now suspecting 31eb486c46 which seems
 let Tor assume that get_interface_address6_via_udp_socket_hack() always
 succeeds.

 Increasing the debug level showed that it fails before the bug message is
 triggered (line number changed due to a local debug patch):

 {{{
 Sep 28 17:26:52.988 [info] {NET} int
 get_interface_address6_via_udp_socket_hack(int, sa_family_t, tor_addr_t
 *): Address that we determined via UDP socket magic is unsuitable for
 public comms.
 Sep 28 17:26:52.988 [warn] {BUG} int tor_addr_is_internal_(const
 tor_addr_t *, int, const char *, int): Bug: tor_addr_is_internal() called
 from src/common/address.c:1651 with a non-IP address of type 49 (on Tor
  0.2.7.3-rc 9a4cac74fd2f4bb3)
 Sep 28 17:26:52.989 [info] {NET} int
 get_interface_address6_via_udp_socket_hack(int, sa_family_t, tor_addr_t
 *): Address that we determined via UDP socket magic is unsuitable for
 public comms.
 Sep 28 17:26:52.989 [warn] {BUG} int tor_addr_is_internal_(const
 tor_addr_t *, int, const char *, int): Bug: tor_addr_is_internal() called
 from src/common/address.c:1651 with a non-IP address of type 49 (on Tor
 }}}

 I probably won't be able to test this theory until tomorrow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17173#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online