[tor-bugs] #16983 [Tor Browser]: Favicon requests not isolated if one opens the tab list dropdown

[Tor Bug Tracker & Wiki]

#16983: Favicon requests not isolated if one opens the tab list dropdown
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  someone_else           |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  major    |    Version:
    Component:  Tor      |   Keywords:  tbb-linkability,
  Browser                |  TorBrowserTeam201509R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:13 gk]:
 > This looks good to me. One thing I was wondering about is that
 inheriting `firstparty` is not necessary anymore. What did it (or was
 supposed to do) in the first place? Or, more direct, why did we need the
 inheritance there given that the icon of the tab is actually set
 elsewhere?

 I implemented inheriting `firstparty` because in both the `tab` and
 `menuitem` case, there is a child `image` element that is responsible for
 downloading and displaying the image. The `image` attributes of `tab` and
 `menuitem` that are set in `tabbrowser.xml` are copied to the `src` of the
 image element. So we also need to propagate the `firstparty` to that child
 element. Inheritance seems the most general way; otherwise we have to
 write code manually to copy the `firstparty` to the child for each case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16983#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online