[tor-bugs] #16069 [Tor]: ipv4 + ipv6 exit : v6 policy is displayed twice, v4 isn't displayed

[Tor Bug Tracker & Wiki]

#16069: ipv4 + ipv6 exit : v6 policy is displayed twice, v4 isn't displayed
--------------------------+-----------------------------------------------
     Reporter:  toralf    |      Owner:
         Type:  defect    |     Status:  needs_review
     Priority:  critical  |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor       |    Version:  Tor: 0.2.7
   Resolution:            |   Keywords:  026-backport, ipv6, PostFreeze027
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+-----------------------------------------------

Comment (by nickm):

 okay, thoughts!

 {{{
 +      log_notice(LD_GENERAL,
 +                 "accept/reject * expands into rules which apply to all
 IPv4 "
 +                 "and IPv6 addresses.");
 }}}

 Maybe this should:
    * mention the actual policy that's getting extended?
    * tell the user what to do if they only wanted it to apply to IPv4?
    * not happen once per policy line per hup. :)
    * Give the user some way to avoid the message if they really did mean
 "all ipv4 and ipv6".

 {{{
 +    if (flags & TAPMP_STAR_IPV4_ONLY) {
 +      family = AF_INET;
 +      tor_addr_from_ipv4h(addr_out, 0);
 }}}

 This doesn't match the documentation, which says that TAPMP_STAR_IPV4_ONLY
 has no effect unless TAPMP_EXTENDED_STAR is also set.

 {{{
 -                                              EXIT_POLICY_IPV6_ENABLED |
 +                                              ~EXIT_POLICY_IPV6_ENABLED |
 EXIT_POLICY_ADD_DEFAULT,0));
 }}}

 Should this bitwise "or" be an "and"?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16069#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online